ISPN-12138 be able to get with other key content types #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavocoding
suggested changes
Aug 6, 2020
karesti
force-pushed
the
ISPN-12138-key-content-type
branch
from
0470b02
to
361db91
Compare
|
@gustavonalle I changed the display names. btw, if I want to add an Integer instead of a text in the value, how can I do it? |
karesti
force-pushed
the
ISPN-12138-key-content-type
branch
from
361db91
to
fef7a2f
Compare
|
I can't seen to make it work.
This happens if I specify the key type and if I don't |
karesti
force-pushed
the
ISPN-12138-key-content-type
branch
3 times, most recently
from
9cbaac1
to
6ea8107
Compare
|
There is an issue in the server that is causing the edit issues: https://issues.redhat.com/browse/ISPN-12315 |
karesti
force-pushed
the
ISPN-12138-key-content-type
branch
from
8b987c2
to
d8f1703
Compare
|
@gustavonalle what do we do with this PR ? |
|
It needs ISPN-12315, I haven't got to it yet, plan to do it for 12.0.0.Final latest |
|
at least the other parts can be integrated if it's working. WDYT ? |
yes |
karesti
force-pushed
the
ISPN-12138-key-content-type
branch
from
d8f1703
to
122dd1e
Compare
|
@gustavonalle please grab a look and tell me if it feels like mergeable now (even if some bugs on the server yet) |
karesti
force-pushed
the
ISPN-12138-key-content-type
branch
from
01cca4e
to
09f236e
Compare
gustavocoding
approved these changes
Oct 12, 2020
|
Merged, thanks @karesti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12138