Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom labels to be defined independently for pods and services #44

Closed
ryanemerson opened this issue May 24, 2022 · 1 comment
Closed

Allow custom labels to be defined independently for pods and services #44

ryanemerson opened this issue May 24, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
0.2.2

Comments

@ryanemerson
Copy link
Contributor

The Operator allows labels to be defined per service or per pod, however the Helm Chart only allows labels to be applied to all created resources via deploy.labels.

We should introduce two new fields podLabels and serviceLabels to differentiate how labels are propagated:

deploy: 
  labels: {} #Applied to all resources
  podLabels: {} # Applied to all Pods
  serviceLabels: {} # Applied to all services
@ryanemerson ryanemerson added the enhancement New feature or request label May 24, 2022
@nicknas
Copy link
Contributor

nicknas commented May 26, 2022

I could do this

@nicknas nicknas mentioned this issue May 30, 2022
Merged
@ryanemerson ryanemerson added this to the 0.2.2 milestone May 30, 2022
ryanemerson pushed a commit that referenced this issue May 30, 2022
@nicknas
Added pod and service custom labels #44
9b38d8c
@domiborges domiborges mentioned this issue Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.2
Development

No branches or pull requests
2 participants
@ryanemerson @nicknas