Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDs should have a separate setting for requests and limits under resources #1366

Closed
ryanemerson opened this issue Dec 23, 2021 · 0 comments
Closed

CRDs should have a separate setting for requests and limits under resources #1366

ryanemerson opened this issue Dec 23, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
2.2.4

Comments

@ryanemerson
Copy link
Contributor

ryanemerson commented Dec 23, 2021 •
edited

Currently the request/limits of the Infinispan pods CPU and memory are both set to the value of the spec.container.cpu and spec.container.memory field respectively. It should be possible for the user to define independent values.

In order to avoid additional fields to the existing CRD version we can add support for optionally defining both values with a : separator is present in the string field.

spec:
  container:
    cpu: "2000m:1000m"
    memory: 2Gi:1Gi:

The order of fields should be <limit>:<requests>.

This affects the Infinispan, Backup and Restore CRs.
@ryanemerson ryanemerson added the enhancement New feature or request label Dec 23, 2021
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Dec 24, 2021
@ryanemerson
CRDs should have a separate setting for requests and limits under res…
8400fcd 
…ources infinispan#1366
@ryanemerson ryanemerson changed the title CRD should have a separate setting for requests and limits under resources CRDs should have a separate setting for requests and limits under resources Dec 24, 2021
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Dec 24, 2021
@ryanemerson
CRDs should have a separate setting for requests and limits under res…
d599f41 
…ources infinispan#1366
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Dec 24, 2021
@ryanemerson
CRDs should have a separate setting for requests and limits under res…
5689f79 
…ources infinispan#1366
ryanemerson added a commit that referenced this issue Jan 17, 2022
@ryanemerson
CRDs should have a separate setting for requests and limits under res…
8a8c6d2 
…ources #1366
@ryanemerson ryanemerson added this to the 2.2.4 milestone Jan 17, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 15, 2022
@ryanemerson
CRDs should have a separate setting for requests and limits under res…
e337751 
…ources infinispan#1366
rigazilla pushed a commit that referenced this issue Feb 15, 2022
@ryanemerson @rigazilla
CRDs should have a separate setting for requests and limits under res…
8f8631b 
…ources #1366
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 16, 2022
@ryanemerson
Revert "CRDs should have a separate setting for requests and limits u…
48b7ce8 
…nder resources infinispan#1366"

This reverts commit 8f8631b.
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 16, 2022
@ryanemerson
Revert "Revert "CRDs should have a separate setting for requests and …
3a9f94f 
…limits under resources infinispan#1366""

This reverts commit 48b7ce8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.4
Development

No branches or pull requests
1 participant
@ryanemerson