Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve probe settings #1387

Closed
ryanemerson opened this issue Feb 3, 2022 · 0 comments
Closed

Improve probe settings #1387

ryanemerson opened this issue Feb 3, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@ryanemerson
Copy link
Contributor

ryanemerson commented Feb 3, 2022

Current probes settings prevent Infinispan pod being available sooner than 10s. With a 10s periodCheck the readiness always happen in multiple of 10s. (If the server starts in 11s its marked as ready in 20s by k8s).

Given the pods are deployed sequentially on K8s StatefulSets after previous nodes are ready, this has a cumulative effect. If a user deploys a cluster with replicas=3, and it takes 11s for a pod to be ready, the whole cluster won't be available for at least 1 minute even it could theoretically start up in 33s.

Current probe settings:

readinessProbe: 
  httpGet: 
    path: rest/v2/cache-managers/default/health/status
    port: 11223
    scheme: HTTP
  initialDelaySeconds: 10
  timeoutSeconds: 80
  periodSeconds: 10
  successThreshold: 1
  failureThreshold: 5
  
livenessProbe: 
  httpGet: 
    path: rest/v2/cache-managers/default/health/status
    port: 11223
    scheme: HTTP
   initialDelaySeconds: 10
   timeoutSeconds: 80
   periodSeconds: 10
   successThreshold: 1
   failureThreshold: 5
   
startupProbe: 
  httpGet: 
    path: rest/v2/cache-managers/default/health/status
    port: 11223
    scheme: HTTP
   initialDelaySeconds: 10
   timeoutSeconds: 80
   periodSeconds: 10
   successThreshold: 1
   failureThreshold: 60

Proposal:

readinessProbe: 
httpGet: 
  path: rest/v2/cache-managers/default/health/status
  port: 11223
  scheme: HTTP
initialDelaySeconds: 0
timeoutSeconds: 80
periodSeconds: 10
successThreshold: 1
failureThreshold: 5

livenessProbe: 
httpGet: 
  path: rest/v2/cache-managers/default/health/status
  port: 11223
  scheme: HTTP
 initialDelaySeconds: 0
 timeoutSeconds: 80
 periodSeconds: 10
 successThreshold: 1
 failureThreshold: 5
 
startupProbe: 
httpGet: 
  path: rest/v2/cache-managers/default/health/status
  port: 11223
  scheme: HTTP
 initialDelaySeconds: 1
 timeoutSeconds: 80
 periodSeconds: 1
 successThreshold: 1
 failureThreshold: 600
@ryanemerson ryanemerson added the enhancement New feature or request label Feb 3, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 3, 2022
@ryanemerson ryanemerson added this to the 2.2.4 milestone Feb 3, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 3, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 4, 2022
pruivo pushed a commit that referenced this issue Feb 4, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 15, 2022
rigazilla pushed a commit that referenced this issue Feb 15, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 16, 2022
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant