Authorization #1078
Authorization #1078
Conversation
ryanemerson
added
enhancement
|
@ryanemerson please pay attention that you catch #1079 in this test |
ryanemerson
force-pushed
the
authorization
branch
from
8bd70fc
to
7396a03
Compare
| Infinispan: config.Infinispan{ | ||
| Authorization: config.Authorization{ | ||
| Enabled: c.infinispan.IsAuthorizationEnabled(), | ||
| RoleMapper: "cluster", |
There was a problem hiding this comment.
I'll update this to automatically set the value to "commonName" when client-cert is enabled, but this requirs #1007
ryanemerson
force-pushed
the
authorization
branch
from
7396a03
to
af5c7af
Compare
| @@ -75,6 +75,7 @@ func (c *httpClientConfig) exec(method, path, payload string, headers map[string | |||
| ExpectNoError(err) | |||
| fmt.Printf("%s: %s\n", method, httpURL) | |||
| rsp, err := c.request(httpURL, method, payload, headers) | |||
| ExpectNoError(err) | |||
There was a problem hiding this comment.
@ryanemerson I've identified that sometimes request return net.IsConnectionRefused error. Do you have ideas why it happens and how we can handle this? Otherwise we will get error on test.
CheckExternalAddress has this error handle, probably we need to embedded this handler to the test httpClient
There was a problem hiding this comment.
I've identified that sometimes request return
net.IsConnectionRefusederror. Do you have ideas why it happens and how we can handle this?
No idea the cause tbh. Adding some kind of retry logic to the client makes sense to me 👍
|
Self merging as required for |
Image PR
Config Generator PR