Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watching for the Secrets resources are not owned by the Infinispan CR #1207

Merged
merged 1 commit into from Aug 5, 2021
Merged

Watching for the Secrets resources are not owned by the Infinispan CR #1207

merged 1 commit into from Aug 5, 2021

Conversation

dmvolod
Copy link
Member

@dmvolod dmvolod commented Jul 29, 2021 •
edited

fixes #1206

  • TODO: Migration need to be tested

@dmvolod dmvolod added the Preview WIP. Don't merge yet label Jul 29, 2021
@dmvolod dmvolod force-pushed the issue-1206 branch 4 times, most recently from fb5ea0d to 7060c4c Compare August 2, 2021 09:49
@dmvolod dmvolod removed the Preview WIP. Don't merge yet label Aug 2, 2021
rigazilla
rigazilla reviewed Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@rigazilla rigazilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some questions

pkg/controller/infinispan/infinispan_controller.go Show resolved Hide resolved
pkg/controller/infinispan/infinispan_controller.go Show resolved Hide resolved
pkg/controller/infinispan/infinispan_controller.go Outdated Show resolved Hide resolved
pkg/controller/infinispan/resources/secret/secret_controller.go Show resolved Hide resolved
@ryanemerson ryanemerson merged commit 5530fe5 into infinispan:main Aug 5, 2021
@ryanemerson
Copy link
Contributor

Thanks @dmvolod

@dmvolod dmvolod mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanemerson ryanemerson ryanemerson left review comments

@rigazilla rigazilla rigazilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watching for the Secrets resources are not owned by the Infinispan CR
3 participants
@dmvolod @ryanemerson @rigazilla