Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Pod memory for XSite tests #1252

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Sep 27, 2021

No description provided.

@@ -53,6 +53,9 @@ func crossSiteSpec(name string, replicas int32, primarySite, backupSite, siteNam
},
},
},
Container: ispnv1.InfinispanContainerSpec{
Memory: "1Gi",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pruivo it would be nice to make it configurable via env vars the same as for other tests

Memory = constants.GetEnvWithDefault("INFINISPAN_MEMORY", "512Mi")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want another env variable name? or can I use the value from contansts.go ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be the same as tests run sequentially

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I changed the Jenkinsfile to increase the memory for xsite tests only.
Thanks @dmvolod !

@ryanemerson ryanemerson merged commit b021e6d into infinispan:main Sep 27, 2021
@ryanemerson
Copy link
Contributor

Thanks @pruivo

@pruivo pruivo deleted the t_xsite_test_memory_increase branch September 28, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants