[2.2.x] Graceful Shutdown Refactoring #1154 #1347
Conversation
ryanemerson
force-pushed
the
gracefulshutdown_refactor_2.2.x
branch
from
ffb0010
to
748d184
Compare
| shutdown(internalCaches); | ||
| cachesToShutdown.addAll(icr.getInternalCacheNames()); | ||
| cachesToShutdown.addAll(cacheManager.getCacheNames()); | ||
| shutdown(cachesToShutdown); |
There was a problem hiding this comment.
Shouldn't we define the shutdown function before invoking it?
There was a problem hiding this comment.
Where the function is defined doesn't matter in Javascript. Executing this doesn't throw an error for me.
ryanemerson
force-pushed
the
gracefulshutdown_refactor_2.2.x
branch
2 times, most recently
from
113aab9
to
d95edcf
Compare
|
@ryanemerson Would it make sense to update gracefulShutdown test to use 2 nodes? The test itself would uncover the issue if executed on OpenShift 4.9+ |
ryanemerson
force-pushed
the
gracefulshutdown_refactor_2.2.x
branch
4 times, most recently
from
30ddfcf
to
304c89d
Compare
I've increased the number of nodes to 2, but the test won't fail unless we add a write to one of the caches that encounters the exception. Obviously I can't add that test to the CI until we have a new server image with the fix, so I think I'll create a follow up PR with this change |
ryanemerson
force-pushed
the
gracefulshutdown_refactor_2.2.x
branch
2 times, most recently
from
1a73b3b
to
7458a85
Compare
config/manager/manager.yaml
Outdated
| @@ -37,7 +37,7 @@ spec: | |||
| fieldRef: | |||
| fieldPath: metadata.namespace | |||
| - name: RELATED_IMAGE_OPENJDK | |||
| value: "quay.io/infinispan/server:13.0.1.Final" | |||
| value: "quay.io/infinispan/server:13.0.2.Final" | |||
There was a problem hiding this comment.
👍 It wasn't available when I created the PR and was required for CI. I'll be changing this to 13.0.3.Final as part of the release commit.
ryanemerson
changed the title
ryanemerson
force-pushed
the
gracefulshutdown_refactor_2.2.x
branch
from
7458a85
to
bac098b
Compare
No longer explicitly delete pods on GracefulShutdown, instead scale the StatefulSet once all of the caches have been shutdown on the server.