ISPN-13982: Expand content on setting BASIC intelligence for cluster topology #1592
Conversation
documentation/asciidoc/topics/attributes/community-attributes.adoc
Outdated
Show resolved
Hide resolved
dfitzmau
force-pushed
the
ISPN-13982
branch
2 times, most recently
from
c74936a
to
47bdacc
Compare
dfitzmau
force-pushed
the
ISPN-13982
branch
2 times, most recently
from
63844da
to
7e374dd
Compare
There was a problem hiding this comment.
Content LGTM. The commit message has been lost though, could you update and repush @dfitzmau.
I'll wait for the doc reviewers to accept before merging the PR.
|
|
||
| [NOTE] | ||
| ==== | ||
| {k8s} cluster administrators can define network policies that restrict traffic to {brandname}. | ||
| In some cases network isolation policies can require you to use `BASIC` intelligence even when clients are running in the same {k8s} cluster but a different namespace. | ||
| ==== | ||
|
|
||
| Hot Rod clients must use `BASIC` intelligence when connecting to {brandname} through a `LoadBalancer`, `NodePort`, or {openshiftshort} `Route`. | ||
| `HASH_DISTRIBUTION_AWARE`:: The default intelligence mechanism. Best mechanism for allowing clients to route requests to primary owners, which improves a client's performance. |
There was a problem hiding this comment.
I was thinking about something similar to https://github.com/infinispan/infinispan/pull/10200/files which also organizes the text using some kind of heading.
HASH_DISTRIBUTION_AWARE:: when to use it and why
BASIC:: when to use it and why
But it only makes sense to use it for both terms. If you want to keep it as it is then drop HASH_DISTRIBUTION_AWARE:: and move the sentence back to line 13
There was a problem hiding this comment.
Thanks, @dvagnero .
@ryanemerson and @wfink , do you think I should expand this file to align with the structure in https://github.com/infinispan/infinispan/pull/10200/files ? Maybe I should raise a separate PR to conduct this work because it's out of scope of the request Jira request?
dfitzmau
force-pushed
the
ISPN-13982
branch
2 times, most recently
from
f540a3b
to
540e9d8
Compare
|
Hi, @dvagnero and @oraNod . Might I ask which one of you wants to complete the approval of this PR? |
|
@dfitzmau Yes, I'll approve and merge. Looks fine now but I believe there are additional empty lines at the end of the file or is that just me? |
Yes, you're correct. I have not noticed this too much when I used Atom as my editor. VSC clearly treats empty lines differently. I removed these lines. Thanks! |
|
Thanks @dfitzmau Can you create the backport for 2.2? |
JIRA: https://issues.redhat.com/browse/ISPN-13982