Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

ISPN-3176 Add tests for compatibility mode to server #122

Closed

Conversation

mgencur
Copy link

@mgencur mgencur commented Jul 4, 2013

These tests do not use Memcached for writing, only for reading. If we wanted to test also write ops for Memcached, we would need to specify a custom marshaller for the compatibility mode and this would mean installing a jar file with that class into the modules (is there any other option than installing it as a new module?). I can do that if desired but IMO the current tests might be sufficient.

Martin

@galderz
Copy link
Member

galderz commented Jul 4, 2013

Martin, I suppose this needs to go in 5.3.x branch too? If so, remember to provide a branch. It shouldn't be left to the committer to cherry pick commits in upstream

@galderz
Copy link
Member

galderz commented Jul 4, 2013

Hmmm, error building...: https://gist.github.com/galderz/688b385ce2b1fd3b758e - have you seen this?

@mgencur
Copy link
Author

mgencur commented Jul 4, 2013

Sorry for the branch. Yes, you're right. I'll create another branch for 5.3 (somehow missed the creation of 5.3 branch). I haven't seen the error when building. I'll create the branch on Monday. Sorry for the delay.

@mgencur
Copy link
Author

mgencur commented Jul 8, 2013

Ok. So I won't create a patch for 5.3 branch according the email thread "backporting issues to the 5.3.x". Furthermore, I tried to build the server on the master branch again with latest infinispan-core installed and it passes - no build error.

@galderz
Copy link
Member

galderz commented Aug 30, 2013

Somehow missed this... pulling...

@galderz
Copy link
Member

galderz commented Aug 30, 2013

@mgencur Retesting this I get:

testRestPutHotRodMemcachedGet(org.infinispan.server.test.configs.CompatibilityModeConfigExampleTest): Connection reset
testHotRodPutRestMemcachedGet(org.infinispan.server.test.configs.CompatibilityModeConfigExampleTest): Connection reset

@mgencur
Copy link
Author

mgencur commented Aug 30, 2013

Hmm, looks like I'll need to re-test it. I'll let you know when it's ready. Thanks for looking into this.

@mgencur
Copy link
Author

mgencur commented Sep 2, 2013

I rebased this branch on master branch and fixed the XSLT transformation to work with server:endpoint 6.0 instead of 5.3. All tests pass for me now.

@galderz
Copy link
Member

galderz commented Sep 3, 2013

Hmmm, I still see those failures...

@mgencur
Copy link
Author

mgencur commented Sep 4, 2013

Rebased.

@galderz galderz closed this Sep 4, 2013
@galderz
Copy link
Member

galderz commented Sep 4, 2013

Thanks @mgencur and sorry for the delay!

@mgencur
Copy link
Author

mgencur commented Sep 4, 2013

Thanks Galder. I suppose those failures were gone with different JDK...

@galderz
Copy link
Member

galderz commented Sep 5, 2013

Yeah, JDK7 playing up again on OSX :(, a few too many issues for my liking....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants