Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRCPP-307 Fixed errors #15

Merged
merged 3 commits into from
Dec 9, 2016

Conversation

rigazilla
Copy link
Contributor

@rigazilla rigazilla commented Sep 15, 2016

Fixed some error, added readme and removed x86 configuration (only 64 bit now)
This fixes #14

Copy link

@vchintal vchintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder where the .ddls should be placed is not provided. After testing several times, the documentation for the C# should follow something that was raised here https://issues.jboss.org/browse/JDG-518

@rigazilla
Copy link
Contributor Author

@vchintal I've extended the readme with the instructions on how to change the csproj so if the user prefers to point it's installation directory, instead of copying the dll, knows how to do.

@rigazilla
Copy link
Contributor Author

The example is still not complete, I probably need to add the SSL libraries

@rigazilla
Copy link
Contributor Author

Now the tutorial should without changing the user env settings

Copy link

@slaskawi slaskawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rigazilla Shall I integrate it?

@rigazilla
Copy link
Contributor Author

@slaskawi thanks for the review. @vchintal wdyta, can we integrate?

@slaskawi slaskawi merged commit d222daf into infinispan:master Dec 9, 2016
@slaskawi
Copy link

slaskawi commented Dec 9, 2016

Integrated thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# Tutorial doesn't work
3 participants