SQL Store simple tutorial #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
force-pushed
the
sql-store-h2
branch
2 times, most recently
from
22f9ed0
to
3cea8c8
Compare
|
@wburns I could not make work in the select the use of an alias |
|
@oraNod the Query example can be taken (maybe if you want using a composite key instead of the primary key? Sorry I did not PR the docs but more the code example. But maybe we want to show the composite key in the documentation? Which is the best place, the query protoschema I guess. WDYT @wburns ? |
karesti
force-pushed
the
sql-store-h2
branch
2 times, most recently
from
2cc0030
to
7c6ed9e
Compare
wburns
reviewed
Dec 3, 2021
...nce/sql-store/src/main/java/org/infinispan/tutorial/simple/remote/persistence/DBCreator.java
Show resolved
Hide resolved
...nce/sql-store/src/main/java/org/infinispan/tutorial/simple/remote/persistence/DBCreator.java
Outdated
Show resolved
Hide resolved
...nce/sql-store/src/main/java/org/infinispan/tutorial/simple/remote/persistence/DBCreator.java
Outdated
Show resolved
Hide resolved
...nce/sql-store/src/main/java/org/infinispan/tutorial/simple/remote/persistence/DBCreator.java
Outdated
Show resolved
Hide resolved
...nce/sql-store/src/main/java/org/infinispan/tutorial/simple/remote/persistence/DBCreator.java
Outdated
Show resolved
Hide resolved
infinispan-remote/persistence/sql-store/src/main/resources/sqlQueryCache.xml
Show resolved
Hide resolved
|
@oraNod I left the readme for now, since I want to change it for when we will have the download in the docker image |
wburns
approved these changes
Dec 20, 2021
karesti
force-pushed
the
sql-store-h2
branch
from
340c0fb
to
7dc5344
Compare
wburns
reviewed
Dec 20, 2021
karesti
force-pushed
the
sql-store-h2
branch
from
7dc5344
to
4c18d87
Compare
|
Integrated into main, thanks @karesti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-13194