Add Counter Tutorial #31
Conversation
| return 0; | ||
| }).get(); | ||
|
|
||
| // Check the counter value. It should be the upper-bound (10) |
There was a problem hiding this comment.
This behaviour is not specified in the getValue javadoc. The method's javadoc should mention that if an attempt has been to go pass the upper bound, next time getValue is called, the upper bound would be returned.
The reason I think this is important is because one could expect that if an exception is thrown after trying to update a count beyond its upper bound, the value of the counter would be the value before trying to overflow it?
There was a problem hiding this comment.
so, you think it would make more sense to abort the update if it overflows the counter?
There was a problem hiding this comment.
I did consider that but I don't think aborting the update is a good idea since numbers don't work that way in Java itself. I think the option you've chosen is fine but I'd just javadoc it so that it's clear :)
|
Sorry @pruivo, this needs rebasing. |
|
Actually, let me see if I can solve it myself. |
galderz
force-pushed
the
t_counter_tutorial
branch
from
cb581d4
to
bea0823
Compare
|
I'm integrating this, @pruivo to add the code for the website next. |
No description provided.