Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Add possibility to cache meter binder overriding #126

Closed

Conversation

rutkowskij
Copy link

@rutkowskij rutkowskij commented Nov 5, 2019

I've encountered problem with default cache meter binder and replicated or distributed embedded cache configuration. Default binder uses stats methods wchich agregate stats from all nodes. This behavior results timouts on /actuator/prometheus endpoints (it took several seconds)

I've prepared PR wchich enables overriding default binding configuration (and showed it in associated test)
I've disabled @ComponentScan at all. It was used only for binder configuration wchich is easy to create beans by @Configuration clases. Disabled component scan (wchich was enabled globally) should be also valuable for projects wchich not use that mechanizm at all (especially startup time should decreased)

@rutkowskij
Copy link
Author

rutkowskij commented Nov 6, 2019

if meter binder is configured by autoconfiguration class it can be also easy disabled by

@SpringBootApplication(exclude = InfinispanCacheMeterBinderProviderAutoConfiguration.class)

or

@EnableAutoConfiguration(exclude = InfinispanCacheMeterBinderProviderAutoConfiguration.class)

@karesti
Copy link
Contributor

karesti commented Jan 13, 2020

@rutkowskij thanks for the contribution!

@karesti
Copy link
Contributor

karesti commented Jan 20, 2020

@rutkowskij This patch can't be integrated as it is in the next release, because it needs more thinking and testing.
The problem you raise is that there are timeouts due to the call stats. Is there any particular method you are experiencing this?
Would a bean that interacts with the local cache instead os each node instead of the distributed/replicated values seem like a good option?

@karesti
Copy link
Contributor

karesti commented Jan 20, 2020

@rutkowskij For what is the remove of the component scan, we need to test that removing those annotations won't break actual applications using this starter

@karesti
Copy link
Contributor

karesti commented Jan 20, 2020

I'm closing this issue for now, and opening a JIRA for further work to be done on this matter

@karesti karesti closed this Jan 20, 2020
@karesti
Copy link
Contributor

karesti commented Jan 20, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants