This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Add possibility to cache meter binder overriding #126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered problem with default cache meter binder and replicated or distributed embedded cache configuration. Default binder uses stats methods wchich agregate stats from all nodes. This behavior results timouts on /actuator/prometheus endpoints (it took several seconds)
I've prepared PR wchich enables overriding default binding configuration (and showed it in associated test)
I've disabled
@ComponentScan
at all. It was used only for binder configuration wchich is easy to create beans by@Configuration
clases. Disabled component scan (wchich was enabled globally) should be also valuable for projects wchich not use that mechanizm at all (especially startup time should decreased)