Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

ISPN-11545 session embedded fix #141

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Mar 27, 2020

@karesti karesti force-pushed the ISPN-11545-session-fix branch 3 times, most recently from 64482d4 to 0761b8b Compare March 30, 2020 13:03
@karesti karesti requested a review from pruivo March 30, 2020 13:04
@karesti
Copy link
Contributor Author

karesti commented Mar 30, 2020

@pruivo I will move the tutorials in another PR

Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.adoc mentions the actuator metrics but they don't work for session-remote/embedded.

infinispan-spring-boot-samples/session-embedded/pom.xml Outdated Show resolved Hide resolved
@karesti
Copy link
Contributor Author

karesti commented Apr 2, 2020

session

Covers actuator metrics for caches

@karesti
Copy link
Contributor Author

karesti commented Apr 2, 2020

@pruivo I fixed and pushed

@pruivo
Copy link
Member

pruivo commented Apr 3, 2020

session

Covers actuator metrics for caches

I'm not following, sorry!

@karesti
Copy link
Contributor Author

karesti commented Apr 3, 2020

@pruivo the actuator line specifies that it covers caches, not the session. in any case these examples are moving out once merged
https://issues.redhat.com/browse/ISPN-11549

@pruivo pruivo merged commit 465102f into infinispan:master Apr 3, 2020
@pruivo
Copy link
Member

pruivo commented Apr 3, 2020

integrated! thanks @karesti !

@karesti karesti deleted the ISPN-11545-session-fix branch April 3, 2020 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants