ISPN-11349 lock leak in SIFS FileProvider

infinispan · Feb 18, 2020 · 029e169 · 029e169
1 parent 1f0b6b7
commit 029e169
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/persistence/soft-index/src/main/java/org/infinispan/persistence/sifs/FileProvider.java b/persistence/soft-index/src/main/java/org/infinispan/persistence/sifs/FileProvider.java
@@ -205,22 +205,25 @@ public CloseableIterator<Integer> getFileIterator() {
 
    public void clear() throws IOException {
       lock.writeLock().lock();
-      log.debug("Dropping all data");
-      while (currentOpenFiles.get() > 0) {
-         if (tryCloseFile()) {
-            if (currentOpenFiles.decrementAndGet() == 0) {
-               break;
+      try {
+         log.debug("Dropping all data");
+         while (currentOpenFiles.get() > 0) {
+            if (tryCloseFile()) {
+               if (currentOpenFiles.decrementAndGet() == 0) {
+                  break;
+               }
             }
          }
-      }
-      if (!recordQueue.isEmpty()) throw new IllegalStateException();
-      if (!openFiles.isEmpty()) throw new IllegalStateException();
-      for (File file : dataDir.listFiles()) {
-         if (!file.delete()) {
-            throw new IOException("Cannot delete file " + file);
+         if (!recordQueue.isEmpty()) throw new IllegalStateException();
+         if (!openFiles.isEmpty()) throw new IllegalStateException();
+         for (File file : dataDir.listFiles()) {
+            if (!file.delete()) {
+               throw new IOException("Cannot delete file " + file);
+            }
          }
+      } finally {
+         lock.writeLock().unlock();
       }
-      lock.writeLock().unlock();
    }
 
    public void deleteFile(int fileId) {