ISPN-13798 Make TxCompletionNotificationCommand non blocking #10009
Conversation
| } | ||
| return Collections.emptyMap(); | ||
| return CompletableFutures.completedEmptyMap(); |
There was a problem hiding this comment.
Looks like something is missing, this only ever returns a completed empty map.
There was a problem hiding this comment.
The TxCompletionNotificationCommands is async so, there is nothing to return and this method is no longer used by any other command.
I was in doubt if I should
- return void
- remove the method from
StateTransferManagersince it is only used byTxCompletionNotificationCommands
There was a problem hiding this comment.
When I see this method I expect the returned Stage to complete when all processing related to this method is done. And if I want I can ignore the stage and let it process in the background. If the user can't do this, we should change it to void and document that stuff processes asynchronously in the background.
Also if the only place that uses this is the command and it doesn't require state from the StateTransferManger lets move it to the command directly.
There was a problem hiding this comment.
Deprecated the method from StateTransferManager. 👍
|
Integrated into main, thanks @pruivo ! |
https://issues.redhat.com/browse/ISPN-13798