Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-13756 copy to clipboard #10067

Merged
merged 2 commits into from May 5, 2022

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Apr 22, 2022

@oraNod oraNod added the Documentation Pull request containing only documentation changes label Apr 22, 2022
@oraNod oraNod force-pushed the ISPN-13756/copy-to-clipboard branch from 64931f8 to 02f49c0 Compare April 22, 2022 16:01
@@ -1,6 +1,9 @@
<link rel="canonical" href="https://infinispan.org/docs/stable/titles/cli/cli.html">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jstree/3.3.1/themes/default/style.min.css">
<link rel="stylesheet" href="../../css/css.css">
<link rel="stylesheet" href="/assets/css/clipboard.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this is working as expected? assets directory does not exist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pedro, yeah it seems a little wonky but that href is for the community site only.

https://infinispan.org/assets/css/clipboard.css

This does mean that you don't get the copy to clipboard function when you build locally with maven but I think that's acceptable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if you want to see the copy to clipboard in action it's already there for the Operator docs e.g.: https://infinispan.org/docs/infinispan-operator/2.2.x/operator.html#infinispan-cr_creating-clusters

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that explains why I couldn't check anything locally 🤣

@ryanemerson ryanemerson merged commit 0230b2c into infinispan:main May 5, 2022
@ryanemerson
Copy link
Contributor

Thanks @oraNod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Pull request containing only documentation changes
Projects
None yet
3 participants