ISPN-13846 Creating cache with name more then 256 characters long wil… #10068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanemerson
requested changes
Apr 25, 2022
There was a problem hiding this comment.
I think we also need to impose this restriction on embedded caches, as these will also fail if the cache name is > 255 characters.
As well as the check in GlobalConfigurationManagerImpl we should also check the name size in DefaultCacheManager#defineConfiguration. This will mean template names are also restricted to < 255 characters, so we should update GlobalConfigurationManagerImpl#createTemplate to perform the validation.
core/src/main/java/org/infinispan/globalstate/impl/GlobalConfigurationManagerImpl.java
Outdated
Show resolved
Hide resolved
jabolina
force-pushed
the
ISPN-13846
branch
2 times, most recently
from
24a413c
to
662f8c9
Compare
ryanemerson
reviewed
Apr 25, 2022
core/src/main/java/org/infinispan/globalstate/impl/GlobalConfigurationManagerImpl.java
Outdated
Show resolved
Hide resolved
ryanemerson
reviewed
Apr 25, 2022
core/src/main/java/org/infinispan/manager/DefaultCacheManager.java
Outdated
Show resolved
Hide resolved
ryanemerson
reviewed
Apr 25, 2022
core/src/test/java/org/infinispan/globalstate/GlobalStateTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/infinispan/globalstate/GlobalStateTest.java
Outdated
Show resolved
Hide resolved
…l make the servers crashing on OpenShift
ryanemerson
approved these changes
Apr 25, 2022
|
Thanks @jabolina |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l make the servers crashing on OpenShift
https://issues.redhat.com/browse/ISPN-13846
Just adding a simple size validation in the name received, before starting to create the cache. AFAIK we dont have any validation of this kind, so any suggestion is welcome.
Creating the cache using the console returns the exception code. Creating the cache through the operator does not cause a server restart and the status contains the error message.