ISPN-13842 Infinispan indexing annotations #10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to rebase on top of the current master changes. |
|
@fax4ever needs rebase |
Hi Katia. I'm doing it. |
|
Be careful with adding the |
fax4ever
force-pushed
the
ISPN-13842-new-indexing-annotations
branch
from
daa961d
to
5b797b8
Compare
I rebased, made some changes, but I still need to address well the optionality of the |
| String name; | ||
|
|
||
| @FullTextField | ||
| @Text | ||
| String surname; | ||
| } |
There was a problem hiding this comment.
I added a line feed at the very end of the file
fax4ever
force-pushed
the
ISPN-13842-new-indexing-annotations
branch
3 times, most recently
from
72dd8f8
to
de4caf9
Compare
Keeping the adapting from old annotations to new index model bounded to search5 package, that will be a sort of ACL.
That are: norms, searchAnalyzer, termVector, includeDepth, structure. For decimalScale, we need to support BigDecimal with ProtoStream first.
As we did for legacy annotations values
In order to use query modules without the api, we need to do something like we did for the micrometer dependency, trying to load the class...
fax4ever
force-pushed
the
ISPN-13842-new-indexing-annotations
branch
from
de4caf9
to
374e71c
Compare
|
I've done with the changes. Let me know if we can improve this contribution further. |
|
Merged, thanks |
|
Thanks! |
tristantarrant
pushed a commit
that referenced
this pull request
Jun 7, 2022
ISPN-13648 Use new annotations for embedded cases * Make no reindex from derived entity * Fix protobuf metadata on embedded * Isolate legacy annotations access * Make index field mapping following new index model * Keeping the adapting from old annotations to new index model bounded to search5 package, that will be a sort of ACL. * Support remotely new indexing annotations * Support additional features introduced by the new annotations (norms, searchAnalyzer, termVector, includeDepth, structure). * Test on remote new indexing annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-13842