ISPN-12350 Persistent UUIDs are only used for initial consistent hash #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use the `PersistentUUID` while hashing the node's address. Initially, I was going to only pass the method from `PersistentUUIDManager` in all methods in `ConsistentHashFactory`, but soon enough I realized that was not a good approach. To easily propagate the `PersistentUUID` between operations I created the `Member` class to be used in the factories and the `SyncConsistentHash` that hold the members but delegates most of the functionalities to the `DefaultConsistentHash`. In the factory I kept the existing methods and the new ones will delegate to the existing. I've updated in the `ClusterCacheStatus` to use the new methods. * When the `SyncConsistentHash` is serialized the UUID are also included, so the serialized hash can be larger when compared with the previous version. From the `SyncConsistentHashFactoryTest` we also can see that is possible that more segments are moved.
|
I believe we can close this for now. If necessary, we have the changes to resume working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12350
We need to use the
PersistentUUIDwhile hashing the node's address. Initially, I was going to only pass the converting method fromPersistentUUIDManagerin allConsistentHashFactoryuses, but soon enough, I realized that was not a good approach.To propagate the
PersistentUUIDand be ready to use it during the hash, I created theMemberclass and theSyncConsistentHash. TheMemberonly wraps the values together. TheSyncConsistentHashkeep theMemberobjects, serializing and transferring as needed, and other operations it delegates to theDefaultConsistentHash.In the
ConsistentHashFactory, I kept the existing methods, and the new ones will delegate to the already existing ones.ClusterCacheStatusis using the added methods.The
SyncConsistentHashserializes theUUID, so it may be that we have a larger serialized object here when compared withDefaultConsistentHash. From theSyncConsistentHashFactoryTest, we also can see that it may move more segments.I was definitely struggling with this one. So any review or inputs is really appreciated.