ISPN-13968 Use next inner node if cache segment not found in leaf when using SIFS #10183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-13968
Not actually a problem with the rolling upgrade, but an edge case in SIFS. In a store with multiple segments, a segment can have multiple inner nodes, and recursively, we try to find a cache segment within the node.
The problem happens when a cache segment maps to the next node. Currently, we return and set the keys as not found. I've added a change: if the starting leaf we have is not holding data about the cache segment we want, we then try only the next one; if the next does not have the cache segment, we return.
Using the reproducer Gustavo wrote, we have: