Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-13968 Use next inner node if cache segment not found in leaf when using SIFS #10183

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

jabolina
Copy link
Member

https://issues.redhat.com/browse/ISPN-13968

Not actually a problem with the rolling upgrade, but an edge case in SIFS. In a store with multiple segments, a segment can have multiple inner nodes, and recursively, we try to find a cache segment within the node.

The problem happens when a cache segment maps to the next node. Currently, we return and set the keys as not found. I've added a change: if the starting leaf we have is not holding data about the cache segment we want, we then try only the next one; if the next does not have the cache segment, we return.

Using the reproducer Gustavo wrote, we have:

CHECKING MIGRATED DATA
TOTAL IS: 5000
REQUEST IS: 5000
eviction cache - TEST PASSED
5000 entries

@wburns
Copy link
Member

wburns commented Jun 23, 2022

I have to look closer at the changes, however I would suggest changing the JIRA name to be more descriptive of what actually the issue is.

@jabolina jabolina changed the title ISPN-13968 Rolling upgrades is not syncing all entries ISPN-13968 Use next inner node if cache segment not found in leaf Jun 23, 2022
Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍 Just would like to add some more clarification what is going on.

@jabolina
Copy link
Member Author

jabolina commented Jun 27, 2022

@tristantarrant should we backport?

@jabolina jabolina changed the title ISPN-13968 Use next inner node if cache segment not found in leaf ISPN-13968 Use next inner node if cache segment not found in leaf when using SIFS Jun 27, 2022
@wburns wburns merged commit 26cec23 into infinispan:main Jun 28, 2022
@wburns
Copy link
Member

wburns commented Jun 28, 2022

Integrated into main, thanks @jabolina !

@jabolina jabolina deleted the ISPN-13968 branch June 28, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants