Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-13982: Add note about explicitly setting BASIC intelligence for accessing internal and hidden cluster topology #10200

Merged
merged 1 commit into from Jul 7, 2022

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jun 30, 2022

@dfitzmau dfitzmau added the Documentation Pull request containing only documentation changes label Jun 30, 2022
@@ -5,6 +5,11 @@ Hot Rod clients use intelligence mechanisms to efficiently send requests to {bra
.`BASIC` intelligence
Clients do not receive topology change events for {brandname} clusters, such as nodes joining or leaving, and use only the list of {brandname} Server network locations that you add to the client configuration.

[NOTE]
====
If a client from a remote cluster wants to connect with a {hr_name}} client in your local {brandname} cluster, set your client to use `BASIC` intelligence. This ensures that the remote client can send a request to your {brandname} cluster without experiencing client failover.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but it isn't clear what you want to say here.

Copy link
Contributor

@wfink wfink Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only reason why using BASIC is that the client is behind a Proxy/NAT/LB and does not have the ability to use the physical IP addresses provided by TOPOLOGY_AWARE
Or don't want to use it and rely only on the configured list (and accept the drawbacks)
If you meant the failover for XSite this is a different story and ISPN-13248 is about XSite config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pruivo . My apologies. I received further info and I updated the content. More accurate?

@dfitzmau dfitzmau force-pushed the ISPN-13248 branch 2 times, most recently from 122bfe3 to 261b7a5 Compare July 1, 2022 13:58

.`BASIC` intelligence
Clients do not receive topology change events for {brandname} clusters, such as nodes joining or leaving, and use only the list of {brandname} Server network locations that you add to the client configuration.

[NOTE]
====
Enable `BASIC` intelligence to expose a hidden IP address for a {hr_name} client that sent a request to a remote server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable ... to use the client configuration only if the server cluster should not send back the topology as it is internal and hidden to the client. Examples are LoadBalancer, NAT, Proxy or OpenShift environment.

Copy link
Contributor Author

@dfitzmau dfitzmau Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wfink . I updated the content based on your feedback. Please let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wfink .

@pruivo . Would you be OK to review the revised content?

@dfitzmau dfitzmau changed the title ISPN-13248: Add note about explicitly setting BASIC intelligence for receiving remote client requests ISPN-13248: Add note about explicitly setting BASIC intelligence for accessing internal and hidden cluster topology Jul 1, 2022
@pruivo pruivo merged commit 4790e62 into infinispan:main Jul 7, 2022
@pruivo
Copy link
Member

pruivo commented Jul 7, 2022

merged! thanks @dfitzmau

@dfitzmau dfitzmau mentioned this pull request Jul 22, 2022
@dfitzmau dfitzmau changed the title ISPN-13248: Add note about explicitly setting BASIC intelligence for accessing internal and hidden cluster topology ISPN-13982: Add note about explicitly setting BASIC intelligence for accessing internal and hidden cluster topology Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Pull request containing only documentation changes
Projects
None yet
3 participants