Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14035 Scattered mode NPE with single address in CH #10241

Merged
merged 1 commit into from Aug 2, 2022

Conversation

jabolina
Copy link
Member

https://issues.redhat.com/browse/ISPN-14035

  • Fix NPE when using putAll with only a single node.


@Override
public void testComputeFromNonOwner() {
// no-op as with a single node we do not have a non owner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably use

SkipTestNG.skipIf(true, "Single node test");

or

throw new SkipException("Single node test");

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

* Fix NPE when using `putAll` with only a single node.
@pruivo pruivo merged commit 6a5cff5 into infinispan:main Aug 2, 2022
@pruivo
Copy link
Member

pruivo commented Aug 2, 2022

merged! thanks @jabolina !

@jabolina jabolina deleted the ISPN-14035 branch August 2, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants