ISPN-1938 - Don't validate default conf each time named is parsed #1025
Conversation
|
I'll handle this... |
|
I still need to look into the code, but what's the 5.1.x branch for this? Please name it in the comment |
| @@ -57,6 +58,14 @@ public ConfigurationBuilder() { | |||
| this.unsafe = new UnsafeConfigurationBuilder(this); | |||
| } | |||
|
|
|||
| public boolean isValidateBeforeBuild() { | |||
There was a problem hiding this comment.
We should strive to keep *Configuration and *ConfigurationBuilder classes as clean as possible with only methods that are relevant for configuration building. This methods are not relevant to the user, they do not configure any particular functionality in Infinispan. This really is an internal flag for us to know whether we need to validate the config or not.
So, -1 to these methods being public. If possible, I'd get rid of them too actually.
Having thought a bit further about this, I'd rather get rid of validateBeforeBuild and have an overloaded build(boolean validate) method in ConfigurationBuilder, hopefully in protected/default visibility. ConfigurationBuilderHolder would call dfb.build(false), and the existing build() impl would call the internal build(true). This avoids unnecessary validateBeforeBuild instance variable. WDYT?
There was a problem hiding this comment.
Yeah cool! I like it as well! So the overloaded method is not exposed on the interface then?
|
Have a look again Galder, could not make the method protected/default visibility unfortunately... |
|
Thx Vladimir, that looks better :) |
Master and 5.1.x https://issues.jboss.org/browse/ISPN-1938