Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14064 RESP server should implement COMMAND command #10276

Merged
merged 2 commits into from Sep 1, 2022

Conversation

wburns
Copy link
Member

@wburns wburns commented Aug 25, 2022

  • ERR for any command arguments

https://issues.redhat.com/browse/ISPN-14064

@jabolina
Copy link
Member

CI was crazy, just restarted. Should we add a test for this?

@wburns
Copy link
Member Author

wburns commented Aug 26, 2022

CI was crazy, just restarted. Should we add a test for this?

Sure, I can add a simple one real quick

@wburns
Copy link
Member Author

wburns commented Aug 26, 2022

Actually I don't see a way with lettuce to invoke COMMAND DOCS. Guessing the API was only designed for redis 6, probably why lettuce is on release 6 as well. Guessing once Lettuce 7 comes out we can add a test if we ever remember.

@tristantarrant
Copy link
Member

Actually I don't see a way with lettuce to invoke COMMAND DOCS. Guessing the API was only designed for redis 6, probably why lettuce is on release 6 as well. Guessing once Lettuce 7 comes out we can add a test if we ever remember.

You can use https://github.com/lettuce-io/lettuce-core/wiki/Custom-commands,-outputs-and-command-mechanics

Command<...> response = redis.dispatch(CommandType.COMMAND, new StatusOutput<>(StringCodec.UTF8),
               new CommandArgs<>(StringCodec.UTF8).add("DOCS"));

@tristantarrant
Copy link
Member

I've created wburns#3

@wburns wburns force-pushed the ISPN-14064_redis_command_docs branch from 2f006c8 to 7d5f192 Compare September 1, 2022 16:36
@wburns
Copy link
Member Author

wburns commented Sep 1, 2022

Pulled in your changes, thanks @tristantarrant Just added a very small tweak to limit lines changed.

@jabolina jabolina merged commit 1194f9d into infinispan:main Sep 1, 2022
@jabolina
Copy link
Member

jabolina commented Sep 1, 2022

Merged, thanks @wburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants