Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14187 SoftIndexFileStore not removing log files with expiration #10368

Merged
merged 1 commit into from Oct 7, 2022
Merged

ISPN-14187 SoftIndexFileStore not removing log files with expiration #10368

merged 1 commit into from Oct 7, 2022

Conversation

wburns
Copy link
Member

@wburns wburns commented Oct 4, 2022

  • Unset schedule flag when completing file - set from expiration
  • Make sure nextExpirationTime is set properly if stats already exist

https://issues.redhat.com/browse/ISPN-14187

@wburns wburns force-pushed the ISPN-14187_SIFS_expiration_log branch from a53e44a to f46b778 Compare October 4, 2022 22:08
jabolina
jabolina approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jabolina jabolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just small comments in tests. Gotta love these problems that need to change just a few lines.

core/src/test/java/org/infinispan/persistence/sifs/SoftIndexFileStoreFileStatsTest.java Outdated Show resolved Hide resolved
core/src/test/java/org/infinispan/persistence/sifs/SoftIndexFileStoreFileStatsTest.java Show resolved Hide resolved
core/src/test/java/org/infinispan/persistence/sifs/SoftIndexFileStoreFileStatsTest.java Show resolved Hide resolved
@wburns
ISPN-14187 SoftIndexFileStore not removing log files with expiration
a1efa76 
* Unset schedule flag when completing file - set from expiration
* Make sure nextExpirationTime is set properly if stats already exist
@wburns wburns force-pushed the ISPN-14187_SIFS_expiration_log branch from f46b778 to a1efa76 Compare October 5, 2022 19:43
@wburns
Copy link
Member Author

wburns commented Oct 5, 2022

Updated

@tristantarrant tristantarrant added this to the 14.0.1.Final milestone Oct 7, 2022
@jabolina
Copy link
Member

jabolina commented Oct 7, 2022

Replayed CI, just waiting now.

@jabolina jabolina merged commit 1a02e2d into infinispan:main Oct 7, 2022
@jabolina
Copy link
Member

jabolina commented Oct 7, 2022

Merged, thanks @wburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabolina jabolina jabolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0.1.Final
3 participants
@wburns @jabolina @tristantarrant