ISPN-14278 fix erros in the SQL store examples #10434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domiborges
added
the
Documentation
wburns
reviewed
Nov 15, 2022
| @@ -1,6 +1,6 @@ | |||
| CREATE TABLE Person ( | |||
| name VARCHAR(255) NOT NULL, | |||
| picture VARBINARY(255), | |||
| picture BYTEA, | |||
There was a problem hiding this comment.
This isn't that simple. Unfortunately, it depends upon the DB that is being used. VARBINARY(255) is more popular than BYTEA as that is only Postgres. I am not sure which DB you are trying to tailor the docs to.
There was a problem hiding this comment.
I see! I added a note that it's valid only for PostgreSQL
domiborges
force-pushed
the
ISPN-14278-sql-store
branch
from
6a4158b
to
89dbd9a
Compare
domiborges
force-pushed
the
ISPN-14278-sql-store
branch
from
89dbd9a
to
3ebae6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14278
Updates examples in the sql store docs
Based on feedback from @gustavolira