Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14435 Backwards compatibility broken with InvalidMagicIdException #10558

Merged
merged 1 commit into from Jan 10, 2023
Merged

ISPN-14435 Backwards compatibility broken with InvalidMagicIdException #10558

merged 1 commit into from Jan 10, 2023

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Jan 4, 2023

@pruivo pruivo force-pushed the t_14435 branch 2 times, most recently from 45787e2 to f96bb91 Compare January 5, 2023 13:58
karesti
karesti approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wburns
wburns approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting on CI

@wburns
Copy link
Member

wburns commented Jan 6, 2023

Rerunning CI, looks like it got the OOM as well 😢

@tristantarrant
Copy link
Member

Is testDistExecPutGet([D]) – org.infinispan.client.hotrod.ExecTest related ?

@pruivo
Copy link
Member Author

pruivo commented Jan 10, 2023

@tristantarrant it is not related. It looks like a deadlock caused by the script test-put-get-dist.js being executed in all nodes at the same time.

Caused by: org.infinispan.util.concurrent.TimeoutException: ISPN000299: Unable to acquire lock after 10 seconds for key dist-key and requestor GlobalTransaction{id=60, addr=ExecTest-NodeA, remote=true, xid=Xid{formatId=131077, globalTransactionId=00000000000000000000FFFF0A00956600008A7D63BC12200000007E31,branchQualifier=00000000000000000000FFFF0A00956600008A7D63BC12200000007F0000000000000000}, internalId=-1}. Lock is held by GlobalTransaction{id=59, addr=ExecTest-NodeB, remote=false, xid=Xid{formatId=131077, globalTransactionId=00000000000000000000FFFF0A00956600008A7D63BC12200000007A31,branchQualifier=00000000000000000000FFFF0A00956600008A7D63BC12200000007B0000000000000000}, internalId=-1}

@tristantarrant tristantarrant merged commit d40b159 into infinispan:main Jan 10, 2023
@tristantarrant
Copy link
Member

Merged, thanks

@pruivo pruivo deleted the t_14435 branch January 10, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti approved these changes

@wburns wburns wburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@pruivo @wburns @tristantarrant @karesti