ISPN-14488 REST Task execution with cache #10609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
force-pushed
the
ISPN-14487/rest_task_exec_cache
branch
from
a73ff79
to
6893383
Compare
tristantarrant
changed the title
jabolina
approved these changes
Jan 26, 2023
|
|
||
| return CompletableFuture.supplyAsync(() -> { | ||
| String script = Subject.doAs(request.getSubject(), (PrivilegedAction<String>) () -> scriptingManager.getScript(taskName)); | ||
| return builder.entity(script).build(); |
There was a problem hiding this comment.
should we add a content-type here or unnecessary?
There was a problem hiding this comment.
probably I should set it to text/plain. In theory we could determine it from the script metadata (which is not exposed by the ScriptingManager API).
tristantarrant
force-pushed
the
ISPN-14487/rest_task_exec_cache
branch
2 times, most recently
from
5fa3120
to
90b00a3
Compare
|
@tristantarrant CI reported failures in |
tristantarrant
force-pushed
the
ISPN-14487/rest_task_exec_cache
branch
from
90b00a3
to
56c4dc2
Compare
|
Merged, thanks @tristantarrant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14488
https://issues.redhat.com/browse/ISPN-14489