ISPN-14579 Various RESP commands are requesting wrong size for buffer #10704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
commented
Mar 13, 2023
| import io.netty.channel.ChannelHandlerContext; | ||
| import io.netty.util.CharsetUtil; | ||
|
|
||
| public class Resp3Handler extends Resp3AuthHandler { | ||
| private static final Log log = LogFactory.getLog(MethodHandles.lookup().lookupClass(), Log.class); | ||
| private static final ByteBuf OK = RespRequestHandler.stringToByteBuf("+OK\r\n", ByteBufAllocator.DEFAULT); |
There was a problem hiding this comment.
We couldn't use DEFAULT byte buffer as we want to use a byte buf that is the same type as our underlying protocol. Since netty supports both native and JVM based sockets, any ByteBuf passed down that doesn't match the same type will be first copied into an unpooled copy in the appropriate version. Thus we need to make sure this is the same type as we would configure in our server.
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14579
https://issues.redhat.com/browse/ISPN-14580