New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-14584 Merge infinispan-quarkus into main Infinispan repository #10706
ISPN-14584 Merge infinispan-quarkus into main Infinispan repository #10706
Conversation
Before we can merge this PR we need to upgrade all of the CI agents to have the GraalVM JDK |
830b02f
to
e83c917
Compare
Image pushed for Jenkins build #3:
|
Do we want to build a native every time ? I fear that requires a lot of extra memory/time for every build. |
If we don't do this then I fear we're going to have the same problem that we currently have, which is that PRs with breaking changes are merged and then it's left up to a small subset of the team to fix the issue. Full disclaimer, my primary motivation for creating this PR was because I got fed up of having to fix these issues at image release time. The current infinispan-quarkus Jenkins job takes ~19 minutes, however that builds all of Infinispan as well, so we're probably talking ~15 mins per PR. Another option is that we exclusively build the native parts with GH actions. That way we're not using our hardware and the native build will be created in parallel to the Jenkins job 🎉 |
I don't like the parallel job. Can we try with |
e83c917
to
45887ba
Compare
Seems good to me. I wonder if we can just do a nightly build for native if that would be good enough coverage or not. |
Image pushed for Jenkins build #5:
|
Image pushed for Jenkins build #6:
|
I fear with this approach the failures will continue to be ignored until release time. |
Image pushed for Jenkins build #8:
|
Image pushed for Jenkins build #9:
|
Image pushed for Jenkins build #10:
|
8250872
to
86bbc92
Compare
Image pushed for Jenkins build #12:
|
86cf3a9
to
d3caa44
Compare
Image pushed for Jenkins build #16:
|
@wburns FYI I had to add a new commit to workaround your recent changes to the |
Oops, the newly integrated RESP PR changes this again. If anything it should not be needed now iirc. |
d3caa44
to
999f5bc
Compare
Image pushed for Jenkins build #17:
|
7a84998
to
d24f6db
Compare
Image pushed for Jenkins build #19:
|
d24f6db
to
9b0be64
Compare
Image pushed for Jenkins build #20:
|
9b0be64
to
efe4ed1
Compare
Image pushed for Jenkins build #21:
|
efe4ed1
to
08f9901
Compare
Image pushed for Jenkins build #22:
|
08f9901
to
af6b580
Compare
Add GH action to build native CLI for different platforms on each PR
af6b580
to
3309fa6
Compare
Image pushed for Jenkins build #24:
|
Merged, thanks |
https://issues.redhat.com/browse/ISPN-14584
quay.io/repository/infinispan/server-native:latest
image is updated for each commit tomain
.