Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14584 Merge infinispan-quarkus into main Infinispan repository #10706

Merged
merged 1 commit into from Mar 29, 2023

Conversation

ryanemerson
Copy link
Contributor

https://issues.redhat.com/browse/ISPN-14584

  • Quarkus code updated to work with Infinispan 15.0.0-SNAPSHOT. See 15.0.x infinispan-quarkus#126 for a diff containing these changes only.
  • GH action added so that a GH Release is created on release tag with the native CLI binaries attached.
  • PRs can now request a native image build with the "Native Image Required" label
  • quay.io/repository/infinispan/server-native:latest image is updated for each commit to main.
  • Quarkus integration tests executed as part of Jenkins CI

@ryanemerson
Copy link
Contributor Author

Before we can merge this PR we need to upgrade all of the CI agents to have the GraalVM JDK

@infinispanrelease
Copy link

Image pushed for Jenkins build #3:

quay.io/infinispan-test/server-native:PR-10706

@tristantarrant
Copy link
Member

Before we can merge this PR we need to upgrade all of the CI agents to have the GraalVM JDK

Do we want to build a native every time ? I fear that requires a lot of extra memory/time for every build.

@ryanemerson
Copy link
Contributor Author

Do we want to build a native every time ? I fear that requires a lot of extra memory/time for every build.

If we don't do this then I fear we're going to have the same problem that we currently have, which is that PRs with breaking changes are merged and then it's left up to a small subset of the team to fix the issue. Full disclaimer, my primary motivation for creating this PR was because I got fed up of having to fix these issues at image release time.

The current infinispan-quarkus Jenkins job takes ~19 minutes, however that builds all of Infinispan as well, so we're probably talking ~15 mins per PR.

Another option is that we exclusively build the native parts with GH actions. That way we're not using our hardware and the native build will be created in parallel to the Jenkins job 🎉

@tristantarrant
Copy link
Member

tristantarrant commented Mar 14, 2023

I don't like the parallel job. Can we try with native-image -Ob to disable optimizations for PR builds ?

@wburns
Copy link
Member

wburns commented Mar 14, 2023

Seems good to me. I wonder if we can just do a nightly build for native if that would be good enough coverage or not.

@infinispanrelease
Copy link

Image pushed for Jenkins build #5:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #6:

quay.io/infinispan-test/server-native:PR-10706

@ryanemerson
Copy link
Contributor Author

Seems good to me. I wonder if we can just do a nightly build for native if that would be good enough coverage or not.

I fear with this approach the failures will continue to be ignored until release time.

@infinispanrelease
Copy link

Image pushed for Jenkins build #8:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #9:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #10:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #12:

quay.io/infinispan-test/server-native:PR-10706

@ryanemerson ryanemerson force-pushed the add_quarkus_modules branch 2 times, most recently from 86cf3a9 to d3caa44 Compare March 23, 2023 11:53
@infinispanrelease
Copy link

Image pushed for Jenkins build #16:

quay.io/infinispan-test/server-native:PR-10706

@ryanemerson
Copy link
Contributor Author

@wburns FYI I had to add a new commit to workaround your recent changes to the Resp3Handler. Let me know if this is an issue or there's a better way to handle it.

@wburns
Copy link
Member

wburns commented Mar 23, 2023

@wburns FYI I had to add a new commit to workaround your recent changes to the Resp3Handler. Let me know if this is an issue or there's a better way to handle it.

Oops, the newly integrated RESP PR changes this again. If anything it should not be needed now iirc.

@infinispanrelease
Copy link

Image pushed for Jenkins build #17:

quay.io/infinispan-test/server-native:PR-10706

@ryanemerson ryanemerson force-pushed the add_quarkus_modules branch 2 times, most recently from 7a84998 to d24f6db Compare March 24, 2023 16:19
@infinispanrelease
Copy link

Image pushed for Jenkins build #19:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #20:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #21:

quay.io/infinispan-test/server-native:PR-10706

@infinispanrelease
Copy link

Image pushed for Jenkins build #22:

quay.io/infinispan-test/server-native:PR-10706

Add GH action to build native CLI for different platforms on each PR
@infinispanrelease
Copy link

Image pushed for Jenkins build #24:

quay.io/infinispan-test/server-native:PR-10706

@tristantarrant tristantarrant merged commit 138b1e9 into infinispan:main Mar 29, 2023
3 checks passed
@tristantarrant
Copy link
Member

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants