T 1987 m #1071
Closed
T 1987 m #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,7 +148,7 @@ protected CacheEntry lookupEntryFromCurrentTransaction() { | |||
| // copy for write | |||
| AtomicHashMap<K, V> copy = map == null ? new AtomicHashMap<K, V>(true) : map.copy(); | |||
| copy.initForWriting(); | |||
| cache.put(deltaMapKey, copy); | |||
| cache.withFlags(Flag.SKIP_REMOTE_LOOKUP, Flag.SKIP_CACHE_LOAD).put(deltaMapKey, copy); | |||
There was a problem hiding this comment.
actually for this to be at top efficiency you could execute
cache.withFlags(Flag.SKIP_REMOTE_LOOKUP, Flag.SKIP_CACHE_LOAD)
at Proxy initialization and store the return value in a final field for reause. I'm doing that with most Flag uses in the Lucene directory.
…ing put internally
|
Manik, I missed Sanne's comments and I pushed your original version... I've rebased your commit on top of the original and I'm pushing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1987
And also
t_1987_5for branch5.1.x