Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Embedded Docs #10746

Merged
merged 3 commits into from Apr 21, 2023

Conversation

ryanemerson
Copy link
Contributor

https://issues.redhat.com/browse/ISPN-14584

@dvagnero I've created a very basic version of the docs for our Infinispan embedded extension. This should only be available on the upstream docs. Can you take a look and let me know what this noob docs contributor has missed 馃槂

@tristantarrant
Copy link
Member

You should use

ifdef::community[]
endif::community[]

to mark it as community-only

@ryanemerson ryanemerson changed the title Add quarkus modules to bom Quarkus Embedded Docs Apr 13, 2023
@ryanemerson ryanemerson added the Documentation Pull request containing only documentation changes label Apr 13, 2023
@@ -0,0 +1,13 @@
[id='quarkus_embedded']
:context: quarkus
= Using the Quarkus extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Getting started with {brandname} Quarkus embedded extension"?

@domiborges
Copy link
Member

@ryanemerson Pretty good docs :) I added some docs suggestions.

@ryanemerson
Copy link
Contributor Author

Thanks for the changes @dvagnero, that's much better 馃檪

I'm happy to integrate the changes if somebody wants to do a Squash and Merge.

@domiborges domiborges merged commit 6685830 into infinispan:main Apr 21, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Pull request containing only documentation changes
Projects
None yet
3 participants