Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] ISPN-14530 Override all wrapping methods in EncoderCache #10754

Merged
merged 1 commit into from May 19, 2023
Merged

[14.0] ISPN-14530 Override all wrapping methods in EncoderCache #10754

merged 1 commit into from May 19, 2023

Conversation

tristantarrant
Copy link
Member

@jabolina
Copy link
Member

CI is complaining about some imports.

Maybe I missed some other method, but getAndPutAll was not overridden.

@tristantarrant tristantarrant force-pushed the ISPN-14530/encodercache_overrides-14.0.x branch from 42b3111 to 9d6dced Compare March 31, 2023 06:51
@tristantarrant
Copy link
Member Author

I added that as well as all the *AsyncReturnEntry ones and touch

@tristantarrant tristantarrant force-pushed the ISPN-14530/encodercache_overrides-14.0.x branch from 9d6dced to c64aa88 Compare April 3, 2023 14:39
@tristantarrant tristantarrant added this to the 14.0.10.Final milestone May 15, 2023
@wburns
Copy link
Member

wburns commented May 16, 2023

Compilation errors.

@tristantarrant tristantarrant force-pushed the ISPN-14530/encodercache_overrides-14.0.x branch from c64aa88 to d5ce51d Compare May 19, 2023 12:47
@tristantarrant
Copy link
Member Author

Fixed

wburns
wburns approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI

@wburns wburns merged commit ca47dea into infinispan:14.0.x May 19, 2023
1 check failed
@wburns
Copy link
Member

wburns commented May 19, 2023

Integrated into 14.0, thanks @tristantarrant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabolina jabolina jabolina left review comments

@wburns wburns wburns approved these changes

Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
14.0.10.Final
3 participants
@tristantarrant @jabolina @wburns