ISPN-14724 Create a simple DSL to build Protocol Buffers schema #10761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would put this in the |
|
Moved to the api module and added a real test. |
fax4ever
changed the title
tristantarrant
requested changes
Apr 4, 2023
| .embedded() | ||
| .build(); | ||
|
|
||
| assertThat(proto).isNotBlank(); |
There was a problem hiding this comment.
Maybe compare with a .proto in src/test/resources
There was a problem hiding this comment.
This file was supposed to be deleted, but I forgot to do that. I removed it.
The process is tested in the HotRod client module using our validation system and I just added the file comparison.
|
Thanks @tristantarrant, I think I fixed it. |
With the Infinispan indexing annotations options
|
Merged, thanks |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14724