New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-14484 Document server tracing and client propagation #10770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fax4ever few questions for you.
You've done an amazing job. The docs look great!
I have few changes locally that I'd like to push + some more information depending on your answers. Can you please take a look at my comments?
---- | ||
<1> Globally enables the tracing. | ||
<2> The OTLP (OpenTelemetry protocol) exporter is the recommended format to export tracing data. | ||
<3> Specify here service name. The default name is `Infinispan Server`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fax4ever what exactly is the default? Infinispan Server
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvagnero yes it is
= Hot Rod client tracing propagation | ||
The HotRod client fully supports the OpenTelemetry tracing propagation from the client to the Infinispan server. | ||
|
||
It means that if the OpenTelemetry tracing is configured both on client VM and on the {brandname} server, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you configure tracing on client VM? Should we include the step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the client technology, not by us. For instance a Quarkus OpenTelemetry extension or a SpringBoot OpenTelemetry module can be added for instance.
|
||
For our case. | ||
|
||
* Pass the following system properties to {brandname} Server at startup: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user wants to update the configuration, do they need to stop the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes at the moment the configuration is taken at server startup time... more improvements will come
Great job @dvagnero. Merged it! |
https://issues.redhat.com/browse/ISPN-14484