JakartaEE packages and Quarkus 3.0.x #10791
Conversation
ryanemerson
changed the title
ryanemerson
force-pushed
the
jakarata_server
branch
from
ef3e1db
to
0a657c3
Compare
ryanemerson
force-pushed
the
jakarata_server
branch
2 times, most recently
from
1c3576c
to
625a4b2
Compare
ryanemerson
force-pushed
the
jakarata_server
branch
2 times, most recently
from
373afcb
to
1be0911
Compare
ryanemerson
force-pushed
the
jakarata_server
branch
from
1be0911
to
4c55ae8
Compare
hibernate/cache-commons/pom.xml
Outdated
| @@ -45,7 +45,7 @@ | |||
| <dependency> | |||
| <groupId>org.jboss.narayana.jta</groupId> | |||
| <artifactId>narayana-jta-jakarta</artifactId> | |||
| <version>5.11.2.Final</version> | |||
| <version>${version.jboss.narayana.javaee}</version> | |||
There was a problem hiding this comment.
what is the error using 6.0.0.Final?
There was a problem hiding this comment.
No idea. It was already set to 5.11.2.Final before this PR. I have reverted back to this.
There was a problem hiding this comment.
It looks like it is broken in main
[INFO] org.infinispan:infinispan-hibernate-cache-commons:jar:15.0.0-SNAPSHOT
[INFO] +- org.jboss.narayana.jta:narayana-jta-jakarta:jar:5.11.2.Final:test
[INFO] \- org.jboss.narayana.jta:narayana-jta:jar:5.13.1.Final:test
[INFO] --- dependency:3.1.1:tree (default-cli) @ infinispan-hibernate-cache-spi ---
[INFO] org.infinispan:infinispan-hibernate-cache-spi:jar:15.0.0-SNAPSHOT
[INFO] \- org.jboss.narayana.jta:narayana-jta:jar:5.13.1.Final:test
[INFO] org.infinispan:infinispan-hibernate-cache-v62:jar:15.0.0-SNAPSHOT
[INFO] +- org.jboss.narayana.jta:narayana-jta-jakarta:jar:5.13.1.Final:test
[INFO] \- org.jboss.narayana.jta:narayana-jta:jar:6.0.0.CR1:test
There was a problem hiding this comment.
my suggestion
- hibernate/cache-commons/pom.xml
remove <version> and add <scope>test</scope> to narayana-jta-jakarta dependency
- hibernate/cache-v62/pom.xml
remove
- <!-- https://mvnrepository.com/artifact/org.jboss.narayana.jta/narayana-jta -->
- <dependency>
- <groupId>org.jboss.narayana.jta</groupId>
- <artifactId>narayana-jta</artifactId>
- <version>6.0.0.CR1</version>
- <scope>test</scope>
- </dependency>
remove <version>5.13.1.Final</version> from narayana-jta-jakarta
There was a problem hiding this comment.
Thanks @pruivo, I have applied your suggestion but removed narayana-jta-jakarta entirely as that does not exist for 6.0.x
There was a problem hiding this comment.
Right, Narayana dropped javaee! 👍
ryanemerson
force-pushed
the
jakarata_server
branch
3 times, most recently
from
875e67c
to
a91642a
Compare
|
Rebased on top of the recent killing spree of JavaEE modules. Requires #10847 before merging. |
ryanemerson
force-pushed
the
jakarata_server
branch
from
a91642a
to
7a35e0a
Compare
|
is there anything missing? I can press the button 🥳 |
ryanemerson
force-pushed
the
jakarata_server
branch
from
7a35e0a
to
9e6a146
Compare
|
Everything is here. I just re-pushed, but the only change was removing the unused property so we should be good to go if the build passes. |
- ISPN-14745 Narayana 6.0.0.Final - ISPN-14746 Fabric8 kubernetes-client 6.5.1 - ISPN-14747 jboss-threads 3.5.0.Final - ISPN-14748 Smallrye Mutiny 2.1.0 - ISPN-14764 Upgrade to plexus-utils 3.5.1 - ISPN-14734 Quarkus 3.0.0.CR2
ryanemerson
force-pushed
the
jakarata_server
branch
from
9e6a146
to
5f86c3e
Compare
|
merged! thanks @ryanemerson ! |
https://issues.redhat.com/browse/ISPN-14734
https://issues.redhat.com/browse/ISPN-14735
https://issues.redhat.com/browse/ISPN-14745
https://issues.redhat.com/browse/ISPN-14746
https://issues.redhat.com/browse/ISPN-14747
https://issues.redhat.com/browse/ISPN-14764
The JCache modules make use of the-javaeejars as the spec is effectively frozen and will not transition to using the Jakarta packages: jsr107/jsr107spec#415.I have had to include the Quarkus 3.0.0.CR2 work in this PR, as without it native compilation will always fail. For that reason we should probably squash all of the commits before merging.