Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14817 Move some Hot Rod client tests to the server testsuite #10869

Merged

Conversation

tristantarrant
Copy link
Member

@tristantarrant tristantarrant commented Apr 27, 2023

https://issues.redhat.com/browse/ISPN-14817

  • ClusteredIT: incorporate ExtensionsIT suite run in CONTAINER mode
  • HotRodCacheOperations: incorporate APITest and RemoteAsyncAPITest. Parameterized for protocol versions and types
  • HotRodCacheQueries: incorporate ProtobufHotRodRestEntityIT
  • HotRodCacheEvents: incorporate JsonEventsTest, ClientEventsTest, ClientFilterEventsTest, ClientCustomEventsTest, ClientClusterEventsTest
  • SslTest, SslAuthenticationTest, SecureExecTest: removed as more in-depth tests are already present in the server testsuite

Part 1 of many. Do not close the Jira

@tristantarrant tristantarrant force-pushed the ISPN-14817/move_client_tests branch 2 times, most recently from 2440d45 to 9f49705 Compare April 28, 2023 09:39
* ClusteredIT: incorporate ExtensionsIT suite run in CONTAINER mode
* HotRodCacheOperations: incorporate APITest and RemoteAsyncAPITest. Parameterized for protocol versions and types
* HotRodCacheQueries: incorporate ProtobufHotRodRestEntityIT
* HotRodCacheEvents: incorporate JsonEventsTest, ClientEventsTest, ClientFilterEventsTest, ClientCustomEventsTest,
    ClientClusterEventsTest
* SslTest, SslAuthenticationTest, SecureExecTest: removed as more in-depth tests are already present in the server testsuite
@tristantarrant
Copy link
Member Author

Failures are unrelated

@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/ubi-minimal
FROM registry.access.redhat.com/ubi9/ubi-minimal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually use ubi8 for the upstream images, as we needed to baseline the JDK based image on that for Openshift compatibility. That being said, I should probably upgrade the cli and server-native images to ubi9 as we don't have similar downstream considerations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually a reason to stick with ubi8 is that the builder image we rely on ubi-quarkus-native-image is based upon ubi8, so it would be good to test with the same runtime image. I'll look into updating the modules to use container based native compilation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that's a leftover from running it on my local box which has a much newer glibc than CI.

@ryanemerson ryanemerson merged commit a4ed878 into infinispan:main May 9, 2023
3 of 4 checks passed
@ryanemerson
Copy link
Contributor

Thanks @tristantarrant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants