Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14633 LPUSH and LPUSHX commands #10912

Merged
merged 1 commit into from
May 16, 2023
Merged

ISPN-14633 LPUSH and LPUSHX commands #10912

merged 1 commit into from
May 16, 2023

Conversation

karesti
Copy link
Contributor

@karesti karesti commented May 9, 2023 •
edited

@karesti karesti changed the title Ispn 14633 lpush commands ISPN-14633 LPUSH and LPUSHX commands May 9, 2023
@karesti karesti force-pushed the ISPN-14633-lpush-commands branch 2 times, most recently from 80ef2ea to f66dd89 Compare May 9, 2023 08:41
@wburns
Copy link
Member

wburns commented May 10, 2023

Is this a duplicate of #10909 ?

@karesti
Copy link
Contributor Author

karesti commented May 10, 2023

no, depends on the other, but first I need to finish your review :))

@karesti karesti marked this pull request as draft May 10, 2023 15:40
@karesti karesti force-pushed the ISPN-14633-lpush-commands branch 2 times, most recently from cf43829 to aa4ea18 Compare May 16, 2023 07:29
@karesti karesti marked this pull request as ready for review May 16, 2023 07:29
@karesti karesti requested a review from jabolina May 16, 2023 07:32
@karesti
Copy link
Contributor Author

karesti commented May 16, 2023

@jabolina @wburns this is ready for review

jabolina
jabolina reviewed May 16, 2023
View reviewed changes
Copy link
Member

@jabolina jabolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things.

server/resp/src/test/java/org/infinispan/server/resp/RespListCommandsTest.java Show resolved Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/list/internal/PUSH.java Outdated Show resolved Hide resolved
@karesti karesti force-pushed the ISPN-14633-lpush-commands branch from aa4ea18 to 88d3436 Compare May 16, 2023 13:52
@karesti
Copy link
Contributor Author

karesti commented May 16, 2023

@jabolina I reported your changes

@jabolina jabolina merged commit 4239f87 into infinispan:main May 16, 2023
3 of 4 checks passed
@jabolina
Copy link
Member

Integrated into main, thanks @karesti!

@karesti karesti deleted the ISPN-14633-lpush-commands branch May 17, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabolina jabolina jabolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@karesti @wburns @jabolina