ISPN-14907 Implement RESP "cluster shards" command #10930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me cover this a bit more with tests for single nodes, too |
|
@jabolina open a new jira if you have two parts |
|
I'll put an on-hold on this momentarily while I work on some fixes first. |
|
Please add rows to the table in |
jabolina
force-pushed
the
ISPN-14229-shards
branch
from
e2c76ef
to
2ff098d
Compare
jabolina
changed the title
|
@karesti Created a JIRA and updated this PR. |
jabolina
force-pushed
the
ISPN-14229-shards
branch
from
2ff098d
to
0f671ea
Compare
jabolina
force-pushed
the
ISPN-14229-shards
branch
3 times, most recently
from
bfa3068
to
e8d16ba
Compare
wburns
reviewed
May 31, 2023
server/resp/src/main/java/org/infinispan/server/resp/RespCommand.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/RespCommand.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/RespCommand.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/connection/COMMAND.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
jabolina
force-pushed
the
ISPN-14229-shards
branch
2 times, most recently
from
a86a01d
to
50b40a0
Compare
wburns
reviewed
May 31, 2023
| byte[] possibleBytes = bytes; | ||
| if (length == possibleBytes.length) { | ||
| boolean matches = true; | ||
| for (int i = 0; i < possibleBytes.length; ++i) { |
There was a problem hiding this comment.
Technically this is adding an additional case insensitive char comparison, but I guess that is okay.
jabolina
force-pushed
the
ISPN-14229-shards
branch
2 times, most recently
from
8534dae
to
927678f
Compare
wburns
reviewed
Jun 1, 2023
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/CLUSTER.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
jabolina
force-pushed
the
ISPN-14229-shards
branch
from
927678f
to
36f28e9
Compare
wburns
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Another thought is we could retry or wait for a topology update to complete. But this is probably too complex for this with little benefit.
I am mainly just concerned about using a null owner and ignoring some backups when they aren't named... I think having something is better than just not including them.
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Outdated
Show resolved
Hide resolved
jabolina
force-pushed
the
ISPN-14229-shards
branch
2 times, most recently
from
c07032f
to
475062d
Compare
|
Yeah, we could create all the required fields using the address.toString() as a placeholder for name and address. And we can say the node's health, so I put it to use |
wburns
reviewed
Jun 2, 2023
server/resp/src/main/java/org/infinispan/server/resp/commands/cluster/SHARDS.java
Show resolved
Hide resolved
wburns
reviewed
Jun 2, 2023
jabolina
force-pushed
the
ISPN-14229-shards
branch
from
475062d
to
8b847ef
Compare
|
Fixed the test. |
|
Integrated into main, thanks @jabolina ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14229
CLUSTER SHARDScommand.This is part 1, do not close the JIRA yet.