ISPN-14659 STRLEN command #10932
Merged
ISPN-14659 STRLEN command #10932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
approved these changes
May 11, 2023
wburns
requested changes
May 11, 2023
| byte[] keyBytes = arguments.get(0); | ||
|
|
||
| CompletableFuture<Long> strLenAsync = handler.cache().getAsync(keyBytes) | ||
| .thenCompose(buff -> CompletableFuture.completedFuture(Long.valueOf(buff!=null ? buff.length : 0))); |
There was a problem hiding this comment.
Don't use thenCompose for synchronous invocations, just use thenApply.
Suggested change
| .thenCompose(buff -> CompletableFuture.completedFuture(Long.valueOf(buff!=null ? buff.length : 0))); | |
| .thenApply(buff -> buff!=null ? buff.length : 0L); |
| RedisCommands<String, String> redis = redisConnection.sync(); | ||
| String key = "strlen"; | ||
| String val = "Hello"; | ||
| String app = " World"; |
There was a problem hiding this comment.
This test needs to test non ASCII characters as well, and verify the behavior with REDIS server. Unfortunately, https://redis.io/commands/strlen/ doesn't state what it does for non UTF-8 characters if it counts the bytes or the characters. (I have a feeling it may be the latter).
There was a problem hiding this comment.
Added test. Redis strings are sequence of bytes, so it counts bytes:
127.0.0.1:6379> set euro "€"
OK
127.0.0.1:6379> strlen euro
(integer) 3
wburns
approved these changes
May 16, 2023
|
Integrated into main, thanks @rigazilla ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STRLEN command
https://issues.redhat.com/browse/ISPN-14659