ISPN-14628 LLEN command #10960
Merged
ISPN-14628 LLEN command #10960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jabolina rebased from main |
jabolina
approved these changes
May 22, 2023
|
Integrated into main, thanks @karesti! |
wburns
reviewed
May 23, 2023
| byte[] key = arguments.get(0); | ||
| EmbeddedMultimapListCache<byte[], byte[]> listMultimap = handler.getListMultimap(); | ||
|
|
||
| return CompletionStages.handleAndCompose(listMultimap.size(key) ,(size, t) -> { |
There was a problem hiding this comment.
Couldn't this just use thenApply on the stage returned from size method?
There was a problem hiding this comment.
you mean not using the handleAndCompose and instead using directly thenApply ?
server/resp/src/main/java/org/infinispan/server/resp/commands/list/LLEN.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14628