Added more configs to dev ispn configuration for console test needs. #11003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
previously approved these changes
Jun 1, 2023
|
@tristantarrant what do you think on this one? |
|
I'm ok with the metrics. I'm not ok with the default cache and the configuration template. Those do not exist in a real server, and building against them would create a disalignment. |
| <transport cluster="${infinispan.cluster.name:cluster}" stack="${infinispan.cluster.stack:tcp}" node-name="${infinispan.node.name:}"/> | ||
| <security> | ||
| <authorization/> | ||
| </security> | ||
| <local-cache name="default"/> |
There was a problem hiding this comment.
Replace with a distributed cache that inherits from the template defined below.
|
Merged, thanks |
|
Hi team, sorry - seems that I have missed the email notifications from this PR. Thanks for the changes and merging. Anna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #10999