Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14629 LMOVE command #11017

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Jun 1, 2023

@rigazilla
Copy link
Contributor

not related to this PR, but:
index()
could be optimized accessing the list from begin or end depending whether the index is before or after values.size()/2

@karesti karesti added Question and removed Question labels Jun 6, 2023
@karesti karesti force-pushed the ISPN-14629-lmove branch 2 times, most recently from 419f970 to 93df0f4 Compare June 6, 2023 16:11
@karesti karesti added the On Hold label Jun 7, 2023
@karesti karesti force-pushed the ISPN-14629-lmove branch 4 times, most recently from a02ea60 to edbfe83 Compare June 15, 2023 14:58
@karesti
Copy link
Contributor Author

karesti commented Jun 19, 2023

@jabolina anything else missing ?

Copy link
Member

@jabolina jabolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things and we're good.

@karesti
Copy link
Contributor Author

karesti commented Jun 19, 2023

I pushed the change @jabolina

@karesti
Copy link
Contributor Author

karesti commented Jun 19, 2023

@jabolina I updated again

Copy link
Member

@jabolina jabolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rigazilla rigazilla merged commit 6c30d85 into infinispan:main Jun 20, 2023
3 of 4 checks passed
@rigazilla
Copy link
Contributor

merged, thanks all!

@karesti karesti deleted the ISPN-14629-lmove branch June 20, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants