ISPN-14597 SINTER resp command #11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigazilla
force-pushed
the
SINTER-14597
branch
2 times, most recently
from
62734d7
to
fcc32c0
Compare
rigazilla
force-pushed
the
SINTER-14597
branch
3 times, most recently
from
62c1284
to
1365923
Compare
Merged
karesti
previously requested changes
Jun 27, 2023
server/resp/src/main/java/org/infinispan/server/resp/commands/set/SCARD.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/set/SCARD.java
Outdated
Show resolved
Hide resolved
jabolina
reviewed
Jun 28, 2023
multimap/src/main/java/org/infinispan/multimap/impl/function/SGetFunction.java
Outdated
Show resolved
Hide resolved
server/resp/src/test/java/org/infinispan/server/resp/DistributedSetTest.java
Show resolved
Hide resolved
multimap/src/main/java/org/infinispan/multimap/impl/SetBucket.java
Outdated
Show resolved
Hide resolved
multimap/src/main/java/org/infinispan/multimap/impl/EmbeddedSetCache.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/hash/HGET.java
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/set/SINTERCARD.java
Outdated
Show resolved
Hide resolved
server/resp/src/main/java/org/infinispan/server/resp/commands/set/SMEMBERS.java
Outdated
Show resolved
Hide resolved
server/resp/src/test/java/org/infinispan/server/resp/RespSetCommandsTest.java
Outdated
Show resolved
Hide resolved
rigazilla
force-pushed
the
SINTER-14597
branch
3 times, most recently
from
c6e1ae8
to
bc63ca0
Compare
jabolina
reviewed
Jul 3, 2023
multimap/src/main/java/org/infinispan/multimap/impl/function/set/SSetFunction.java
Outdated
Show resolved
Hide resolved
server/resp/src/test/java/org/infinispan/server/resp/test/RespTestingUtil.java
Outdated
Show resolved
Hide resolved
I changed the implementation to use atomic getAll, this way the behaviour should be the same as Redis. Looking at the docs I can't find anything special for the intersect commands implemented here. please squash the commits if all good. getAll is a separate commit |
jabolina
approved these changes
Jul 5, 2023
Comment on lines
+87
to
+88
| // await(set.add(NAMES_KEY, ELAIA)); | ||
| // assertValuesAndOwnership(NAMES_KEY, ELAIA); |
There was a problem hiding this comment.
Do we have an issue with these?
There was a problem hiding this comment.
oh, it's a mistake. I restored these lines in #10906. Thanks!
| * @param keys, collection of keys to be get | ||
| * @return {@link CompletionStage} containing a {@link } | ||
| */ | ||
| public CompletableFuture<Map<K, SetBucket<V>>> getAll(Set<K> keys) { |
There was a problem hiding this comment.
Maybe in future changes, we update to avoid returning the bucket as it is just an abstraction.
|
|
||
| public static Set<WrappedByteArray> checkTypesAndReturnEmpty(Collection<SetBucket<WrappedByteArray>> buckets) { | ||
| var iter = buckets.iterator(); | ||
| // access all items to check for error |
karesti
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of commands for sets.
Code was almost the same, so this PR refers to 3 jiras.
https://issues.redhat.com/browse/ISPN-14597
SINTER SINTERCARD SINTERSTORE
https://issues.redhat.com/browse/ISPN-14598
SMEMBERS
https://issues.redhat.com/browse/ISPN-14595
SCARD