Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14610 ZCOUNT #11067

Merged
merged 1 commit into from
Jul 3, 2023
Merged

ISPN-14610 ZCOUNT #11067

merged 1 commit into from
Jul 3, 2023

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Jun 29, 2023 •
edited

@rigazilla
Copy link
Contributor

mvn build reports several "unchecked conversion" warnings on generics. Most of them can be fixed just adding the proper parameter (i.e. see this PR)

@karesti karesti force-pushed the ISPN-14610-zcount branch 2 times, most recently from f8cea41 to eb076d6 Compare June 30, 2023 08:43
@karesti
Copy link
Contributor Author

karesti commented Jun 30, 2023

@rigazilla I fixed those that can be fixed, but we need to bypass the compare and use "Object" to check scores only, so while some warnings can be fixed, others need to be ignored

@karesti karesti force-pushed the ISPN-14610-zcount branch 2 times, most recently from 9dcf3ae to 58193dd Compare June 30, 2023 09:33
rigazilla
rigazilla previously approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@rigazilla rigazilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

multimap/src/main/java/org/infinispan/multimap/impl/SortedSetBucket.java Outdated Show resolved Hide resolved
@jabolina jabolina self-requested a review June 30, 2023 13:53
@karesti
Copy link
Contributor Author

karesti commented Jun 30, 2023

@jabolina the scores can be duplicated. This is why we need "higher" and "lower" elements but exclude them from subset to grab all the elements in a range that have the same score. However, when we "exclude" a score, we need floor or ceiling, to find the element that migh be of that score, but the first one (in case duplicated scores)

@karesti karesti force-pushed the ISPN-14610-zcount branch 2 times, most recently from aa8d21a to 706d865 Compare June 30, 2023 15:30
@karesti karesti removed the On Hold label Jul 1, 2023
@karesti karesti force-pushed the ISPN-14610-zcount branch 6 times, most recently from 21e421e to 747a57a Compare July 3, 2023 11:57
@jabolina
Copy link
Member

jabolina commented Jul 3, 2023 •
edited

The failures in the RESPAuthorizationTest will be inspected when we work on https://issues.redhat.com/browse/ISPN-14894. They are not related with the changes here.

@jabolina jabolina merged commit 5472e58 into infinispan:main Jul 3, 2023
3 of 4 checks passed
@jabolina
Copy link
Member

jabolina commented Jul 3, 2023

Integrated, thanks @karesti!

@karesti karesti deleted the ISPN-14610-zcount branch July 4, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabolina jabolina jabolina approved these changes

@rigazilla rigazilla rigazilla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@karesti @rigazilla @jabolina