New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-15060 Provide a proxable Cache API to get create queries #11127
Conversation
5553d81
to
64e1e52
Compare
b1271cd
to
cd9a3a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I think we should deprecate the SearchFactory hinting at the "new" way. Please also work on the docs
commons/all/src/main/java/org/infinispan/commons/api/query/Query.java
Outdated
Show resolved
Hide resolved
Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this
6906d57
to
376cac8
Compare
@fax4ever anything else needed ? docs only ? |
Yes. We need a feedback on the doc update only and I think that we can merge it. |
@fax4ever @domiborges do you have some time to review this or may we open a follow up jira for query docs ? |
Hi! I'll check it in the afternoon |
Thank you @domiborges |
287ba4d
to
252af81
Compare
Thank you @domiborges for the review! I added your commit ISPN-15060 docs review |
wow 3 approvals :) |
252af81
to
d12b1e5
Compare
Thank you @karesti |
https://issues.redhat.com/browse/ISPN-15060
Draft => Before to finish the implementation, I need to double-check with @tristantarrant if this was the idea he described on the chat.done!