Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-15060 Provide a proxable Cache API to get create queries #11127

Merged
merged 4 commits into from Sep 13, 2023

Conversation

fax4ever
Copy link
Contributor

@fax4ever fax4ever commented Jul 17, 2023

https://issues.redhat.com/browse/ISPN-15060

Draft => Before to finish the implementation, I need to double-check with @tristantarrant if this was the idea he described on the chat. done!

@fax4ever fax4ever requested a review from karesti July 17, 2023 07:42
@fax4ever fax4ever force-pushed the ISPN-15060 branch 2 times, most recently from 5553d81 to 64e1e52 Compare July 17, 2023 10:15
@fax4ever fax4ever changed the title ISPN-15060 Provide a proxable RemoteCache API to get the query factory ISPN-15060 Provide a proxable Cache API to get create queries Aug 6, 2023
@fax4ever fax4ever force-pushed the ISPN-15060 branch 7 times, most recently from b1271cd to cd9a3a3 Compare August 11, 2023 13:47
@fax4ever fax4ever marked this pull request as ready for review August 11, 2023 14:06
@fax4ever fax4ever marked this pull request as draft September 5, 2023 09:42
Copy link
Member

@tristantarrant tristantarrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think we should deprecate the SearchFactory hinting at the "new" way. Please also work on the docs

@fax4ever
Copy link
Contributor Author

fax4ever commented Sep 5, 2023

Nice. I think we should deprecate the SearchFactory hinting at the "new" way. Please also work on the docs

Thanks for the review!
I applied the changes and also simplified the solution a little (I removed QueryProvider(s)).
About the deprecation I deprecated QueryFactory#create(queryString), I don't know if we can deprecate the Search#getQueryFactorys since they contain other methods we're not replacing with the new API.

@fax4ever fax4ever marked this pull request as ready for review September 5, 2023 12:26
Copy link
Contributor

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this

@karesti
Copy link
Contributor

karesti commented Sep 11, 2023

@fax4ever anything else needed ? docs only ?

@fax4ever
Copy link
Contributor Author

@fax4ever anything else needed ? docs only ?

Yes. We need a feedback on the doc update only and I think that we can merge it.

@karesti
Copy link
Contributor

karesti commented Sep 11, 2023

@fax4ever @domiborges do you have some time to review this or may we open a follow up jira for query docs ?

@domiborges
Copy link
Member

Hi! I'll check it in the afternoon

@fax4ever
Copy link
Contributor Author

Hi! I'll check it in the afternoon

Thank you @domiborges

@fax4ever
Copy link
Contributor Author

Thank you @domiborges for the review! I added your commit ISPN-15060 docs review

@fax4ever
Copy link
Contributor Author

wow 3 approvals :)

@karesti karesti merged commit ae1483f into infinispan:main Sep 13, 2023
3 of 4 checks passed
@fax4ever
Copy link
Contributor Author

Thank you @karesti

@fax4ever fax4ever deleted the ISPN-15060 branch September 13, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants