ISPN-13612 InvalidatedNearRemoteCache can persist stale values in cas… #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
added
the
14.0.x
jabolina
approved these changes
Aug 7, 2023
Comment on lines
76
to
77
| MetadataValue<V> nearValue = nearcache.get(key); | ||
| if (nearValue == null) { |
There was a problem hiding this comment.
Could a concurrent get retrieve the placeholder here? Should we extend the if check?
There was a problem hiding this comment.
Yes, it can... I forgot to add || nearValue.value() == null. Good catch.
...nt/src/test/java/org/infinispan/client/hotrod/near/InvalidationNearCacheConcurrencyTest.java
Show resolved
Hide resolved
wburns
force-pushed
the
ISPN-13612_near_cache_stale
branch
from
b7b9b57
to
5c6fe3c
Compare
|
Updated to fix one of the comments, unfortunately I am not sure of a better way then a sleep without making the test very complex to fix the timing issue :( |
pruivo
reviewed
Aug 8, 2023
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/near/NearCache.java
Show resolved
Hide resolved
pruivo
reviewed
Aug 8, 2023
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/near/AssertsNearCache.java
Show resolved
Hide resolved
client/hotrod-client/src/test/java/org/infinispan/client/hotrod/near/MockNearCacheService.java
Outdated
Show resolved
Hide resolved
...nt/src/test/java/org/infinispan/client/hotrod/near/InvalidationNearCacheConcurrencyTest.java
Outdated
Show resolved
Hide resolved
Yes, I guess I erroneously thought you couldn't use it in the new client, but looking at the code closer I was wrong :D |
wburns
force-pushed
the
ISPN-13612_near_cache_stale
branch
from
5c6fe3c
to
66c37e0
Compare
|
Review comments are addressed as I could. Just adding documentation note as I forgot to push before. |
wburns
force-pushed
the
ISPN-13612_near_cache_stale
branch
from
66c37e0
to
90915d5
Compare
|
Updated |
pruivo
reviewed
Aug 9, 2023
client/hotrod/src/main/java/org/infinispan/hotrod/near/NearCacheService.java
Outdated
Show resolved
Hide resolved
client/hotrod-client/src/main/java/org/infinispan/client/hotrod/near/NearCacheService.java
Outdated
Show resolved
Hide resolved
client/hotrod/src/main/java/org/infinispan/hotrod/near/NearCacheService.java
Outdated
Show resolved
Hide resolved
client/hotrod/src/main/java/org/infinispan/hotrod/near/NearCacheService.java
Outdated
Show resolved
Hide resolved
…e of concurrent access
wburns
force-pushed
the
ISPN-13612_near_cache_stale
branch
from
90915d5
to
03acc1c
Compare
|
Updated trace messages. |
pruivo
approved these changes
Aug 9, 2023
|
merged! thanks @wburns ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e of concurrent access
https://issues.redhat.com/browse/ISPN-13612