Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14606 ZUNION, ZINTER, ZUNIONSTORE, ZINTERSTORE #11205

Merged
merged 1 commit into from
Aug 11, 2023
Merged

ISPN-14606 ZUNION, ZINTER, ZUNIONSTORE, ZINTERSTORE #11205

merged 1 commit into from
Aug 11, 2023

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Aug 10, 2023

@karesti karesti requested a review from jabolina August 10, 2023 13:54
@karesti karesti force-pushed the ISPN-14606-ZUNION-ZINTER-commands branch 2 times, most recently from f618f80 to 7e46edf Compare August 10, 2023 14:41
jabolina
jabolina reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@jabolina jabolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion, everything looks good, though.

Also, does Redis has some sort of isolation for the sets accessed in this operation? I couldn't find anything. If so, maybe we add a note in the documentation.

multimap/src/main/java/org/infinispan/multimap/impl/SortedSetBucket.java Show resolved Hide resolved
...er/resp/src/main/java/org/infinispan/server/resp/commands/sortedset/internal/AGGCommand.java Show resolved Hide resolved
...er/resp/src/main/java/org/infinispan/server/resp/commands/sortedset/internal/AGGCommand.java Outdated Show resolved Hide resolved
@karesti
Copy link
Contributor Author

karesti commented Aug 11, 2023

Just one small suggestion, everything looks good, though.

Also, does Redis has some sort of isolation for the sets accessed in this operation? I couldn't find anything. If so, maybe we add a note in the documentation.

As you said, in the docs nothing is specified...

@karesti karesti force-pushed the ISPN-14606-ZUNION-ZINTER-commands branch 2 times, most recently from 288d6c6 to 425b9af Compare August 11, 2023 13:44
@karesti
Copy link
Contributor Author

karesti commented Aug 11, 2023

@jabolina I added your change

@karesti karesti force-pushed the ISPN-14606-ZUNION-ZINTER-commands branch from 425b9af to 6496ed2 Compare August 11, 2023 15:29
@jabolina jabolina merged commit d6591ef into infinispan:main Aug 11, 2023
3 of 4 checks passed
@jabolina
Copy link
Member

Thanks, @karesti!

@karesti karesti deleted the ISPN-14606-ZUNION-ZINTER-commands branch August 12, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabolina jabolina jabolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@karesti @jabolina